-
-
Notifications
You must be signed in to change notification settings - Fork 533
Fix using deprecated virtualenv option --wheel
#3528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix using deprecated virtualenv option --wheel
#3528
Conversation
This turns out to be more involved than I anticipated it to be 😇 I think to be able to get rid of using virtualenv to install wheel,
I think it might be this line that's causing issues: https://github.com/tox-dev/pyproject-api/blob/46dc443b1a33599fb76f869bd911fd4827eafb0d/src/pyproject_api/_frontend.py#L179 |
You're correct here. |
With pyproject-api 1.9.1, this works and fixes the issue for me. |
0c2a4d3
to
a2dd77a
Compare
Signed-off-by: Bernát Gábor <[email protected]>
a2dd77a
to
4d68d2a
Compare
The CI started failing when virtualenv deprecated the
--wheel
and--no-wheel
options (in 20.31.0). This PR makes it so that tox doesn't run into this deprecation which caused the tests to fail that checked for some expected stdout which were then unexpectedly containing the deprecation message.tox -e fix
)(Existing test were failing, so if this improves the situation, I consider this box ticked 😉)
added news fragment innot user-facing, or it it?docs/changelog
folderupdated/extended the documentationAPI/CLI didn't change